Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Makefile to actually run all tests on all platforms #2

Merged
merged 1 commit into from
Aug 12, 2015

Conversation

chriskuehl
Copy link
Contributor

Previously due to an error in the Makefile, we were only testing against the ubuntu (resolves to ubuntu:trusty) and debian (resolves to debian:jessie) images, whoops!

Also adds a missing dependency on the deb tests and fixes the tests to work on lucid (need to install timeout, and use a different pip installation method).

@chriskuehl chriskuehl force-pushed the fix-makefile branch 2 times, most recently from af10aba to 5ac4e0c Compare August 12, 2015 20:22
@bukzor
Copy link
Contributor

bukzor commented Aug 12, 2015

:shipit:

🚢 🇮🇹

chriskuehl added a commit that referenced this pull request Aug 12, 2015
Fix Makefile to actually run all tests on all platforms
@chriskuehl chriskuehl merged commit 471e0f4 into Yelp:master Aug 12, 2015
chriskuehl pushed a commit that referenced this pull request Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants