feat: error as string #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! I think that’s a good idea, so I’ll go ahead and merge it. As for the documentation, I’m currently a bit tied up, but if you can make a PR for that as well, I’d really appreciate it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The advantage is that, unlike
(),StringimplementsDisplay. I get that you made it()to avoid having a library that users have to depend on at runtime, but this should be a fair compromise.Makes it easier to do debugging (and some libraries want error types to necessarily implement
Display).P.S.: just realized that in my previous PR (#41) I forgot to update the README and docs accordingly. You should probably do that. Or I can, if you prefer, I don't mind.