chore: update indexmap & serde-bridge #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8d351e to
eb114c0
Compare
Xuanwo
reviewed
Feb 20, 2025
src/parsers/toml.rs
Outdated
| /// Toml with unknown field handler support | ||
| /// | ||
| /// This parser will ignore unknown fields and call the handler with the path of the unknown field. | ||
| pub struct TomlIgnored { |
There was a problem hiding this comment.
Hi, I have a feeling that this API doesn't belong to serfig. Maybe we can move it to downstream?
There was a problem hiding this comment.
make sense, let me put it in the downstream first
There was a problem hiding this comment.
Thank you for this. I believe other parts of this PR is good to go.
There was a problem hiding this comment.
let me rename this pr's title to reduce the scope of change
577f741 to
7165119
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.