Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to trust X-Forwarded-Proto header with websocket connections #4437

Closed
totaam opened this issue Dec 9, 2024 · 1 comment
Closed

option to trust X-Forwarded-Proto header with websocket connections #4437

totaam opened this issue Dec 9, 2024 · 1 comment
Labels
enhancement New feature or request network

Comments

@totaam
Copy link
Collaborator

totaam commented Dec 9, 2024

Similar to #4436 but more fine-grained: the same http proxy can provide both http and https connections.

X-Forwarded-Proto could be used to trust that the client connection is actually encrypted.

We are assuming here that we want things configured this way.
This usually implies that the connection to the proxy is not a security concern.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-Proto

@totaam totaam added enhancement New feature or request network labels Dec 9, 2024
@totaam
Copy link
Collaborator Author

totaam commented Dec 9, 2024

This is not as useful as I was hoping it was going to be - because the client is the one that has to trust the connection.
That said, the http headers are now exposed for all websocket connections, so the server could also potentially make use of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request network
Projects
None yet
Development

No branches or pull requests

1 participant