Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate include guard names in xf_erosion.hpp and xf_median_blur.hpp #96

Closed
dsp-avt opened this issue Dec 3, 2021 · 2 comments
Closed

Comments

@dsp-avt
Copy link

dsp-avt commented Dec 3, 2021

In the Vitis Vision Library xf_erosion.hpp defines _XF_MEDIAN_BLUR_ as an include guard, however, xf_median_blur.hpp also uses this same name. The include guard name in xf_erosion.hpp should be changed to _XF_EROSION_ to allow both xf::cv::erode() and xf::cv::medianBlur() to be used in the same accelerator.

@vt-lib-support
Copy link
Collaborator

Hi @dsp-avt ,

Thanks for reporting this. We will correct it soon.

vt-lib-support pushed a commit that referenced this issue Apr 27, 2022
b8aa0ac Merge pull request #98 from changg/round2-mk
0dafa9e fix
69ce1de Merge pull request #97 from changg/round2-mk
33635fb fix utils.mk
bb09f85 Merge pull request #96 from tuol/fix_cr_1125397
26bfd12 upate description.json for GUI
6142bf4 Merge pull request #95 from tuol/fix_cr1110852
18b6b69 add description for cscmvSingleHBM
489d6fe Merge pull request #94 from changg/wa_u280
c83ed11 WA for u280
70d666c Revert "wa for xilinx_u280_xdma_201920_3"
27306c5 Merge pull request #93 from changg/wa_u280_2019
2b4ec88 wa for xilinx_u280_xdma_201920_3
af1d094 Merge pull request #92 from liyuanz/replace_cflags
a9ff957 replace cflags with clflags
eb58a83 Merge pull request #91 from tuol/fix_cr_1110852
c9ca9ab add description to L2/tests/cscmvSingleHbm
b8e0210 Merge pull request #90 from tuol/fix_cr_1083211
75204c8 remove 'exclude' from description.json
965b2e0 Merge pull request #88 from liyuanz/replace_blacklist
0e87eee replace whiltelist/blacklist to allowlist/blocklist
ad26de7 Merge pull request #87 from liyuanz/next
3db258c increase time
def14fe Merge pull request #85 from changg/add_extraflags
f8a6122 fix makefile
031de2c Merge pull request #84 from liyuanz/next
f10953c increase time
4745f24 Merge pull request #83 from changg/fix_utils
6fb2652 fix utisl
7d9278f Merge pull request #82 from liyuanz/replace_targets
c1c2de5 update targes
68ae52e Merge pull request #80 from changg/metadata
6225d51 draft metadata files
e74cf2b change 2021.2_stable_latest to 2022.1_stable_latest

Co-authored-by: sdausr <sdausr@xilinx.com>
vt-lib-support pushed a commit that referenced this issue Apr 27, 2022
f7d1abc Merge pull request #122 from tuol/disable_2_case
ae62691 disable 2 case due to U250 platform change
3af143e Merge pull request #118 from tuol/fix_cr_1122542
3e7f919 temporally disable L3/tests/mlp, due to U250 platform change
1728d13 update opts.cfg
98d3f3f Merge pull request #117 from yuanqian/next
8639708 remove email from Jenkinsfile:https://jira.xilinx.com/browse/CR-1124831
18a7458 Merge pull request #116 from changg/wa_u280_201920
86e28ef WA for xilinx_u280_xdma_201920_3
07abe54 Merge pull request #114 from liyuanz/replace_cflags
7cb157c replace cflags with clflags
0196ded Merge pull request #113 from changg/cov_fix
fc100b4 cov fix
b201f43 cov fix
14067e6 Merge pull request #110 from liyuanz/next
bbe42e9 fix bug
257677d Merge pull request #109 from changg/pr_108
79db50c fix makefiles
984a71c update Makefile and utils
daf9820 Merge pull request #106 from liyuanz/replace_blacklist
28fe2ed replace whiltelist/blacklist to allowlist/blocklist
981b5a2 Merge pull request #105 from changg/pr_104
2f45a63 add time for hw_build
a21b8db add time
7256e35 add time
5f2c36a Merge pull request #102 from changg/add_extraflags
acce305 fix utils.mk
74536af fix utils.mk
3c0647e Merge pull request #101 from liyuanz/next
fc26744 increase mem
7a1b220 Merge pull request #99 from changg/fix_mks
055c521 fix typ
44ff7b9 fix utils.mk
4050d17 Merge pull request #98 from liyuanz/replace_targets
b0157d6 update targes
e41fc60 Merge pull request #96 from changg/metadata
f6d1e26 draft metadata
0bbb982 change 2021.2_stable_latest to 2022.1_stable_latest

Co-authored-by: sdausr <sdausr@xilinx.com>
@vt-lib-support
Copy link
Collaborator

Hi @dsp-avt ,

This has been corrected in the latest release.

vt-lib-support pushed a commit that referenced this issue May 18, 2023
bf03a6b Merge pull request #96 from tianminr/next
1e4c5b5 modify for os selection
6acfd73 Merge pull request #94 from liyuanz/next
f123e12 update
d8dfe53 update
6af59f4 update
8679e83 Merge pull request #93 from liyuanz/add_memory2
5f3f2fa update

Co-authored-by: sdausr <sdausr@xilinx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants