Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler error - fft_ifft_dit_1ch_graph.hpp #147

Open
nielsvanetten opened this issue Aug 3, 2022 · 5 comments
Open

Compiler error - fft_ifft_dit_1ch_graph.hpp #147

nielsvanetten opened this issue Aug 3, 2022 · 5 comments

Comments

@nielsvanetten
Copy link

nielsvanetten commented Aug 3, 2022

Hi all,

I get an error in the "fft_ifft_dit_1ch_graph.hpp" file when trying to compile it on a A72 cortex application in Vitis.

Error:
.../FFT/3_FFT_DSP/AI_FFT/src/fft_ifft_dit_1ch_graph.hpp:676: undefined reference to fft_4096_tmp2

Same for fft_2048_tmp2, fft_1024_tmp2 etc...

Since I don't get this error when compiling this on the AI-engine level, I believe that this is probably due to different versions of the C++ compiler.

It seems the C++ compiler for the cortex application doesnt recognize: alignas(32) extern cint32_t fft_4096_tmp2[FFT4096_SIZE]

@nielsvanetten
Copy link
Author

error

@nielsvanetten
Copy link
Author

think i found the bug:
https://stackoverflow.com/questions/10422034/when-to-use-extern-in-c

variable needs to be declared into the "fft_ifft_dit_1ch_graph.hpp" file

@nielsvanetten
Copy link
Author

nielsvanetten commented Aug 4, 2022

basically I think the best way to fix this is to just remove the extern and const parameters since these variables are not used in multiple source files, I will make a push request

@nielsvanetten
Copy link
Author

nielsvanetten commented Aug 4, 2022

see pull request, this solved my issue

@xflorentw
Copy link

Hi @nielsvanetten
I am not sure this is a right solution as this might affect the code on the AIE.
In my opinion, the DSPLib code should not be visible by the PS code. Thus I would recommend to add the following in the graph to hide the code inside the graph to the PL:
#if defined(AIESIM) || defined(X86SIM) || defined(ADF_FRONTEND)

vt-lib-support pushed a commit that referenced this issue Oct 24, 2022
99206d5 Merge pull request #155 from RepoOps/update_readme_5
82bd621 update README
b5ef682 update README
7b500f9 Merge pull request #154 from liyuanz/next
037e51a update description.json
5872eb0 Merge pull request #153 from tuol/cr_1143013_3
aa45dfe lower freq
42b28e6 Merge pull request #152 from RepoOps/update_doc_url_3
7b44d6c fix urk
42d5a75 Merge pull request #147 from RepoOps/update_doc_url_3
862bb40 Merge pull request #151 from tuol/cr_1143013
1f81ca6 fix frequency
a38e08c Merge pull request #150 from liyuanz/next
76cded4 add memory
4e4d7e4 Merge pull request #149 from tuol/cr_1140566
b212735 remove broken sym link
3896c56 Merge pull request #148 from tuol/cr_1142096
0ec8716 fix hw_build of L3/tests/rtm2d
48dee48 update url and branch in doc
13991c5 Merge pull request #146 from tuol/fix_version
79a503b update version to 2022.2
e44f356 Merge pull request #143 from RepoOps/update_makefile_20220908-212141
e2ab4a4 Merge branch 'next' into update_makefile_20220908-212141
327cbd9 update Makefile with 2.0.8 version

Co-authored-by: sdausr <sdausr@xilinx.com>
vt-lib-support pushed a commit that referenced this issue Oct 19, 2023
d5c1b1c Merge pull request #165 from yuanqian/fix_api_meta-2
0d165fe update
3120f1e add visble and target_domain
32f9bf9 [fix bug]1.fix abs path in makefile of imagepoint 2. api.json of L2 visible=false
3cc0a3f [doc]add L2 features and tutorial
90a6c05 [doc]leagal
6bbe7d5 Merge pull request #163 from yunleiz/next
1c9d082 [doc] refine tutorial
4f7d0c1 [format] L3
2a9463b Merge branch 'next' of https://gitenterprise.xilinx.com/FaaSApps/xf_ultrasound into next
b67854f [doc]features/details_L2.rst add delay sample mult scanline
cc64796 [format] L3
858df2d [L3] refine accuracy
beb874b Merge pull request #160 from congt/next
cfae80f Merge pull request #162 from yunleiz/next
ddfcd7b [L3] remove small test
9c8b25c Merge pull request #161 from yunleiz/next
cec21dd [L3] refine makefile
8e5fff5 Merge branch 'next' of gitenterprise.xilinx.com:FaaSApps/xf_ultrasound into next
0cff04d [L2]add description for graph_imagepoints and graph_focusing
293dad7 [L2] fixed bugs
a0d89b4 [L2]correct description.json for L2 graph_scanline
9a8a73f [L2] fixed a makefile bug
df8f760 [L2]description.json for L2 mult delay sample and scanline
72b3403 [L2]add graph_delay.json
ef3dc2f [L2 tutorial]
abef6b4 [meta data]
331686f Merge pull request #159 from yunleiz/next
454ffab [remove] data2png move to models
ceff96b [doc] L3 doc update
0856fa7 Merge pull request #158 from yunleiz/next
d94c36e [L3] refine meta data and description
c322805 [L3] update meta and format json.hpp
df5048e [refine]L2 imagepoint remove hardnumber
0d5169f [L1 legal]add header for us_example_parameter
daf6f6d [L3] add license
c25e8e1 [L3] refine makefile
aa28f20 [L3] refine makefile
234ce6e [L3] refine api.json
67b4d83 Merge pull request #157 from yunleiz/next
4a2592c [model] format
b6bff22 [L3] scanline AllinAIE pl freq change to 400
a55e4d7 Merge pull request #152 from changg/aie_cli
085fdc4 Merge pull request #156 from yunleiz/next
db9a639 Merge branch 'next' into aie_cli
0fa1b41 [L1 L3] move dev branch
46a1491 Merge pull request #155 from yunleiz/next
0d9fdae [L3] move models from dev branch
38df5eb [L3] move models from dev branch
346a48e Merge pull request #154 from congt/next
af30489 [L3] move from dev branch
4225747 [L2]add data/ for graph_scanline
b0ce2b3 resolve conflict
8e4cd3a resolve conflict
4196533 resolve conflict
f672081 [standlization]
3263251 fix
f65de04 ad fix
189e34c format json, and add config file
2ee80ac Revert "convert to config"
2b5a833 convert to config
11298bc port to unified command for aie apis
1724ce1 Merge pull request #147 from yunleiz/next
b2aa8b0 [clean] merge mult
e02354e Merge branch 'next' of gitenterprise.xilinx.com:FaaSApps/xf_ultrasound into next
e7cfa29 Merge pull request #150 from congt/next
c934c58 [models] format
1d3e3ab [L3] add scanline_AllinAIE
8d64da9 [add file]L2/include delay sample and mult
cb8bf65 Merge branch 'next' of https://gitenterprise.xilinx.com/FaaSApps/xf_ultrasound into next
c542d5f [standlization]clang-format and legal of makefile
9af2c9f [add L2] graph imagepoint, focusing, scanline
459d38c Merge pull request #148 from congt/next
ff73213 remove unused files
d52f71b [update] interpolation
1968881 [format] apodi and interp
b868bee [E2E]fix coding style of L2/tests/graph_delay/aie_graph/graph.cpp
10fd877 [E2E]add L1
4aafd8f [refine] api.json
9c1d672 [standlization]add L1 L2 of delay sample mult
c7cb72a [api.json] refine api.json
ad3e52d [E2E] add apodization and interpolation unit test
41f76ab Merge pull request #104 from liyuanz/revert-103-next
2f3827b Revert "set visible=False in api.json"
9c88301 Merge pull request #103 from liyuanz/next
3daf775 update
741f03e update
a5bb4e3 Merge pull request #98 from changg/fix_target_domain
211e922 update
a545cf3 fix target domain
42480c3 change 2023.1_stable_latest to 2023.2_stable_latest
f925024 Merge pull request #95 from changg/fix_copyright
d0bf220 fix copyright

Co-authored-by: sdausr <sdausr@xilinx.com>
vt-lib-support pushed a commit that referenced this issue Nov 19, 2024
c1e5f77 Merge pull request #147 from RepoOps/update_20241029-202327
dc9dd28 clang format

Co-authored-by: sdausr <sdausr@xilinx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants