Merge pull request #742 from XiaoMi/hotfix/1.5.12

fix: checkbox list do not change but rerender
XiaoMi · Oct 28, 2019 · 9f4adf1 · 9f4adf1
2 parents 5dca19f + 742643c
commit 9f4adf1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/components/checkbox/CheckBox.js b/components/checkbox/CheckBox.js
@@ -2,6 +2,7 @@ import React, { Component } from 'react'
 import PropTypes from 'prop-types'
 import Base from './Base'
 import MultipleCheckboxsOpera from './common'
+import isEqual from 'lodash/isEqual'
 class CheckBox extends Component {
   static _type = 'CheckBox'
   static propTypes = {
@@ -32,6 +33,12 @@ class CheckBox extends Component {
   componentWillUnmount () {
     MultipleCheckboxsOpera.remove(this.props.name || this.props.all)
   }
+  shouldComponentUpdate (nextProps, nextState) {
+    if (this.props.list && isEqual(this.props.list, nextProps.list)) {
+      return false
+    }
+    return true
+  }
   renderCheckBoxGroup (list) {
     return <div>
       {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@hi-ui/hiui",
-  "version": "1.5.11",
+  "version": "1.5.12",
   "description": "HIUI for React",
   "scripts": {
     "test": "node_modules/.bin/standard && node_modules/.bin/stylelint --config .stylelintrc 'components/**/*.scss'",