Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use const generic for computing min/max #2

Draft
wants to merge 1 commit into
base: min-max-better-view
Choose a base branch
from

Conversation

alamb
Copy link

@alamb alamb commented Jul 22, 2024

This is a proposed follow on to apache#6089

It makes the exact comparison a const generic so each min and max gets its own specialized version of the code

However, it does not appear to make any difference

alamb@aal-dev:~/arrow-rs$ critcmp const-grater min-max-better-view
group                       const-grater                            min-max-better-view
-----                       ------------                            -------------------
string view/min nonnull     1.00    222.4±0.65µs 281.1 MElem/sec    1.00    222.6±0.51µs 280.8 MElem/sec
string view/min nullable    1.00    205.0±0.64µs 304.9 MElem/sec    1.00    205.1±0.58µs 304.8 MElem/sec
string/min nonnull          1.08    228.8±0.36µs 273.1 MElem/sec    1.00    211.1±0.59µs 296.0 MElem/sec
string/min nullable         1.00    345.6±0.46µs 180.9 MElem/sec    1.00    346.1±0.55µs 180.6 MElem/sec

XiangpengHao pushed a commit that referenced this pull request Jan 2, 2025
* Implement bulk_delete_request for Azure

* Fix lint and add Azurite bug workaround

* Special 404 error case

* Clippy fix

* Make number of expected headers more conservative and better document invariants

* Use multer for multipart parsing

* Fix clippy

* Fix clippy #2

* Reuse part response buffer

* Make multer conditional to azure feature

* One more HeaderValue::from_static

* Add tests for bulk delete request building and response parsing

* Switch back to manual parsing to avoid multer dependency, other PR suggestions

* Fixes lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant