🐛 fix middleware #17
Merged
🐛 fix middleware #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
Issue
This pull request addresses the bug reported in issue #16. When the
enabledMetrics.httpconfiguration option is set tofalse, certain metrics (requestDuration,requestSize,responseSize) are still being collected, resulting in an error.Changes Made
In the
app/config/plugins.jsfile, I have made the following changes to fix the bug:isHTTPMetricEnabledto store the value ofconfig('enabledMetrics.http').if (!isHTTPMetricEnabled) return;to exit the middleware if HTTP metrics are disabled.enabledMetrics.httpis set tofalse, preventing the error from occurring.Testing
I have tested the changes by following the steps mentioned in the issue description. After applying this fix, I confirmed that the error no longer occurs when accessing endpoints, and no metrics are collected when
enabledMetrics.httpis set tofalse.This pull request resolves the bug and improves the behavior of the metrics collection feature when HTTP metrics are disabled.