Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UIHealthReport.cs #911

Merged
merged 1 commit into from
Feb 20, 2022
Merged

Update UIHealthReport.cs #911

merged 1 commit into from
Feb 20, 2022

Conversation

mipa87
Copy link
Contributor

@mipa87 mipa87 commented Feb 18, 2022

Fix null Entries in UIHealthReport

What this PR does / why we need it:
Fixes the NullReferenceException when accessing null Entries in UIHealthReport. For example in HealthReportExtensions.

Which issue(s) this PR fixes:

Please reference the issue this PR will close: #[issue number]

Special notes for your reviewer:
Occurs when HealthCheckReportCollector.GetHealthReport successfully deserializes the response, but in the requested URI is another API, which provide only "status" property and "entries" are omitted:

{"title":"NotFound","status":404,"detail":"NotFound"}

Does this PR introduce a user-facing change?:
No

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • [#] Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

Fix null Entries in UIHealthReport
@carlosrecuero carlosrecuero merged commit 05e9ceb into Xabaril:master Feb 20, 2022
@carlosrecuero carlosrecuero self-assigned this Feb 20, 2022
@carlosrecuero
Copy link
Collaborator

Thank you for your collaboration @mipa87 . This change has been published on UI packages 6.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants