Issue #566:Customize HTTP status codes for Prometheus exporter #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
reviewed
Sep 22, 2020
test/FunctionalTests/HealthChecks.Prometheus.Metrics/PrometheusResponseWriterTests.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Sep 22, 2020
src/HealthChecks.Prometheus.Metrics/Extensions/ApplicationBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…sResponseWriterTests.cs PR review update Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
|
Merged! A new release build is on appveyor when finished a new package version 3.1.4 will be available on nuget. Thanks @epaulsen for this contribution!! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is needed in order to have prometheus read metrics when health check status is failing.
Which issue(s) this PR fixes: #566
Please reference the issue this PR will close: #566
Special notes for your reviewer:
Does this PR introduce a user-facing change?: No
Please make sure you've completed the relevant tasks for this PR, out of the following list: