Idsvr uriprovider #637
Merged
Idsvr uriprovider #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AroglDarthu Can you explain with more details this scenario? Typically the authority uri is con your configuration and you can use IConfiguration when registered the healtcheck. What kind of scenaris is enabled using the Func<IServiceProvider,Uri>?? |
|
We have dedicated objects that read from configuration. These get
registered via "services.Configure<DedicatedPoco>". So we can just inject
these wherever needed. We prefer to also use these in the healthcheck
instead of giving the healthcheck the knowledge about how to obtain the
values from IConfiguration.
Op vr 25 sep. 2020 13:11 schreef Unai Zorrilla <notifications@github.com>:
… Hi @AroglDarthu <https://github.com/AroglDarthu>
Can you explain with more details this scenario? Typically the authority
uri is con your configuration and you can use IConfiguration when
registered the healtcheck. What kind of scenaris is enabled using the
Func<IServiceProvider,Uri>??
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#637 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKFLZXHWZY4UQOXBQUKZBLSHR3GXANCNFSM4RSEABXA>
.
|
|
@AroglDarthu Please rebase onto |
That would be nice. I'll look into it as soon as I can. |
|
ping @AroglDarthu |
|
@sungam3r sorry for the long wait! |
sungam3r
reviewed
Jul 1, 2022
src/HealthChecks.OpenIdConnectServer/DependencyInjection/IdSvrHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…HealthCheckBuilderExtensions.cs
sungam3r
reviewed
Jul 1, 2022
src/HealthChecks.OpenIdConnectServer/DependencyInjection/IdSvrHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Jul 1, 2022
src/HealthChecks.OpenIdConnectServer/DependencyInjection/IdSvrHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…HealthCheckBuilderExtensions.cs
sungam3r
reviewed
Jul 5, 2022
src/HealthChecks.OpenIdConnectServer/DependencyInjection/IdSvrHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…HealthCheckBuilderExtensions.cs
|
The last step - update API approval file. |
sungam3r
approved these changes
Jul 5, 2022
sungam3r
reviewed
Jul 5, 2022
test/HealthChecks.OpenIdConnectServer.Tests/HealthChecks.OpenIdConnectServer.approved.txt
Outdated
Show resolved
Hide resolved
…dConnectServer.approved.txt
|
@AroglDarthu Problem with line endings. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add overload to IdSvrHealthCheck which enables the uri to be resolved from the IServiceProvider.
Does this PR introduce a user-facing change?:
No
Please make sure you've completed the relevant tasks for this PR, out of the following list:
[ x] Code compiles correctly
[ x] Created/updated tests
[ x] Unit tests passing
[ x] End-to-end tests passing
[ -] Extended the documentation
[ -] Provided sample for the feature