Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable default seq input level #588

Conversation

GustavoFonsecaDeAlmeida
Copy link

@GustavoFonsecaDeAlmeida GustavoFonsecaDeAlmeida commented Jul 16, 2020

What this PR does / why we need it:
This PR adds the possibility to configure a writing level to the seq other than information as a default. This helps because in some companies / projects it can occur the creation of monitoring with different levels of writing. Example: You can configure a lower data retention for verbose level logs that the health check logs are in.

Which issue(s) this PR fixes:
None
Please reference the issue this PR will close: #[issue number]

Special notes for your reviewer:
image

Does this PR introduce a user-facing change?:
No
Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

@GustavoFonsecaDeAlmeida
Copy link
Author

I kept the default value as information for those who already use it do not suffer a behavior change

@GustavoFonsecaDeAlmeida GustavoFonsecaDeAlmeida changed the title Feature/add default seq level Add configurable default seq input level Jul 16, 2020
@GustavoFonsecaDeAlmeida
Copy link
Author

@unaizorrilla , @CarlosLanderas can review ?

@ThiagoBarradas
Copy link

Hello guy! I need this feature too!

All SEQ notification flow (for my company) uses log level as a filter parameter. Your contribution will be amazing to me!

Can someone give us a feedback about this PR approval?

Best regards

@unaizorrilla
Copy link
Collaborator

I'm working on it!!

Thanks for your patience!

@unaizorrilla unaizorrilla merged commit 55ad361 into Xabaril:master Sep 25, 2020
@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants