Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-URI EventStore connection strings. #466

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Add support for non-URI EventStore connection strings. #466

merged 2 commits into from
Mar 30, 2020

Conversation

sjp
Copy link
Contributor

@sjp sjp commented Mar 30, 2020

What this PR does / why we need it:

When attempting to health check a working EventStore connection, I was always getting an Unhealthy response.

After debugging, I discovered that there is an assumption in the code that the connection string must be a URI. This is not always the case, and the connection string I was using was similar to the following one taken from the EventStore documentation:

var connectionString = "ConnectTo=tcp://admin:changeit@localhost:1113; HeartBeatTimeout=500";

I have added support for connection strings in the format shown above.

Which issue(s) this PR fixes:

Please reference the issue this PR will close: #[issue number]

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

@unaizorrilla
Copy link
Collaborator

Hi @sjp

LGTM , fix tests and merge. When a release build finished a new package will be on nuget with 3.0.1

@unaizorrilla unaizorrilla merged commit 48c6e44 into Xabaril:master Mar 30, 2020
@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants