Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle TaskCanceledException when halting #377

Merged
merged 1 commit into from
Dec 30, 2019
Merged

Handle TaskCanceledException when halting #377

merged 1 commit into from
Dec 30, 2019

Conversation

hayer
Copy link
Contributor

@hayer hayer commented Dec 20, 2019

My attempt at fixing #376.

Swallows the TaskCanceledException thrown when stopping.

@unaizorrilla unaizorrilla merged commit 05e732d into Xabaril:master Dec 30, 2019
@unaizorrilla
Copy link
Collaborator

Hi @hayer

Merged, a new release build is on appveyor, when finished a new package with version 3.0.9 AspNetCore.HealthChecks.UI will be available on NuGet.

Thanks for contribute!

@unaizorrilla unaizorrilla self-requested a review December 30, 2019 10:08
@unaizorrilla unaizorrilla added the enhancement New feature or request label Dec 30, 2019
@unaizorrilla unaizorrilla self-assigned this Dec 30, 2019
@hayer hayer deleted the fix-task-cancellation-when-stopping branch December 31, 2019 13:44
@hayer hayer restored the fix-task-cancellation-when-stopping branch December 31, 2019 13:44
@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unaizorrilla unaizorrilla Awaiting requested review from unaizorrilla

Assignees

@unaizorrilla unaizorrilla

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hayer @unaizorrilla