Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure key vault] Add certificates with configurable expiry check #369

Merged
merged 5 commits into from
Dec 17, 2019
Merged

[Azure key vault] Add certificates with configurable expiry check #369

merged 5 commits into from
Dec 17, 2019

Conversation

CarlosLanderas
Copy link
Contributor

@CarlosLanderas CarlosLanderas commented Dec 17, 2019 •
edited
Loading

This PR adds the ability to configure azure key vault certificates with an optional "checkExpired" parameter that will throw an expection when the remote certificate has expired.

Sample:

services
  .AddHealthChecks()
  .AddAzureKeyVault(setup =>
   {
     setup
        .UseKeyVaultUrl("https://landevault.vault.azure.net")
        .AddSecret("cosmos-key")
        .AddKey("Key1")
        .AddCertificate("landecert")
        .AddCertificate("Cert2", checkExpired: true)
        .UseClientSecrets("client", "secret");
   }

@CarlosLanderas CarlosLanderas changed the title Azure key vault certificates [Azure key vault] certificates with configurable expiry check Dec 17, 2019
@CarlosLanderas CarlosLanderas mentioned this pull request Dec 17, 2019
Merged
@CarlosLanderas CarlosLanderas changed the title [Azure key vault] certificates with configurable expiry check [Azure key vault] Add certificates with configurable expiry check Dec 17, 2019
@CarlosLanderas CarlosLanderas merged commit 06c4a37 into master Dec 17, 2019
sungam3r
sungam3r reviewed Dec 17, 2019
View reviewed changes
src/HealthChecks.AzureKeyVault/AzureKeyVaultOptions.cs
@@ -22,6 +22,13 @@ internal IEnumerable<string> Keys
get { return _keys; }
}

internal List<(string, bool)> _certificates = new List<(string key, bool checkExpired)>();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private?

@CarlosLanderas CarlosLanderas deleted the azure-key-vault-certificates branch April 17, 2020 17:14
@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungam3r sungam3r sungam3r left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarlosLanderas @sungam3r