Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement disposable pattern #1959

Merged
merged 3 commits into from
Jul 30, 2023
Merged

Implement disposable pattern #1959

merged 3 commits into from
Jul 30, 2023

Conversation

sungam3r
Copy link
Collaborator

closes #855

@codecov-commenter
Copy link

Codecov Report

Merging #1959 (1335114) into master (cb0871a) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 61.42%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1959      +/-   ##
==========================================
- Coverage   66.36%   66.36%   -0.01%     
==========================================
  Files         252      253       +1     
  Lines        8670     8710      +40     
  Branches      618      624       +6     
==========================================
+ Hits         5754     5780      +26     
- Misses       2761     2771      +10     
- Partials      155      159       +4     
Flag Coverage Δ
ApplicationStatus 26.84% <ø> (ø)
ArangoDb 26.66% <ø> (ø)
Aws.S3 14.37% <ø> (ø)
Aws.SecretsManager 14.63% <ø> (ø)
Aws.Sns 14.85% <ø> (ø)
Aws.Sqs 15.38% <ø> (ø)
Aws.SystemsManager 14.63% <ø> (ø)
Azure.IoTHub 12.88% <ø> (ø)
AzureApplicationInsights 14.79% <0.00%> (ø)
AzureDigitalTwin 35.90% <80.00%> (+0.49%) ⬆️
AzureKeyVault 21.65% <ø> (ø)
AzureSearch 16.21% <ø> (ø)
AzureServiceBus 55.27% <ø> (ø)
AzureStorage 59.23% <ø> (ø)
Consul 22.72% <ø> (ø)
CosmosDb 58.53% <ø> (ø)
Dapr 14.61% <ø> (ø)
DocumentDb 14.18% <ø> (ø)
DynamoDb 12.19% <ø> (ø)
Elasticsearch 39.66% <ø> (ø)
EventStore 61.87% <ø> (ø)
EventStore.gRPC 25.69% <100.00%> (ø)
Gcp.CloudFirestore 12.17% <ø> (ø)
Gremlin 23.23% <ø> (ø)
Hangfire 11.04% <ø> (ø)
IbmMQ 30.96% <ø> (ø)
InfluxDB 15.07% <83.33%> (+1.67%) ⬆️
Kafka 22.15% <100.00%> (ø)
Kubernetes 41.69% <86.95%> (+0.87%) ⬆️
MongoDb 29.01% <ø> (ø)
MySql 33.53% <ø> (ø)
Nats 68.04% <ø> (+0.51%) ⬆️
Npgsql 28.90% <ø> (ø)
OpenIdConnectServer 25.16% <ø> (ø)
Oracle 60.36% <ø> (ø)
Prometheus.Metrics 30.00% <ø> (ø)
Publisher.ApplicationInsights 10.37% <ø> (ø)
Publisher.CloudWatch 19.12% <ø> (ø)
Publisher.Datadog 15.09% <ø> (ø)
Publisher.Prometheus 19.27% <ø> (ø)
Publisher.Seq 40.51% <ø> (ø)
RabbitMQ 48.10% <ø> (ø)
RavenDb 70.61% <ø> (ø)
Redis 66.82% <ø> (ø)
SendGrid 12.00% <0.00%> (ø)
SignalR 28.28% <ø> (ø)
SqlServer 28.74% <ø> (ø)
Sqlite 26.54% <ø> (ø)
System 37.39% <ø> (ø)
UI 65.75% <37.50%> (-0.10%) ⬇️
Uris 61.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
....ApplicationStatus/ApplicationStatusHealthCheck.cs 100.00% <ø> (ø)
...ionInsights/AzureApplicationInsightsHealthCheck.cs 23.40% <0.00%> (ø)
src/HealthChecks.Gremlin/GremlinHealthCheck.cs 100.00% <ø> (ø)
src/HealthChecks.Nats/NatsHealthCheck.cs 80.59% <ø> (+1.49%) ⬆️
src/HealthChecks.RavenDB/RavenDBHealthCheck.cs 82.35% <ø> (ø)
src/HealthChecks.Redis/RedisHealthCheck.cs 79.71% <ø> (ø)
src/HealthChecks.SendGrid/SendGridHealthCheck.cs 17.85% <0.00%> (ø)
...ecks.UI/Extensions/ApplicationBuilderExtensions.cs 0.00% <0.00%> (ø)
...ks.UI/Middleware/UIApiRequestLimitingMiddleware.cs 67.74% <12.50%> (ø)
...I/Core/HostedService/HealthCheckReportCollector.cs 59.90% <33.33%> (+0.38%) ⬆️
... and 11 more

... and 1 file with indirect coverage changes

@sungam3r sungam3r merged commit 64c9cb7 into master Jul 30, 2023
@sungam3r sungam3r deleted the kuber branch July 30, 2023 04:47
@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KubernetesChecksExecutor owns Kubernetes which is diposable, so it should be disposable?
2 participants