Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive PR: Add Application Insights HealthCheck #1891

Merged
merged 78 commits into from
Jul 11, 2023

Conversation

cieciurm
Copy link
Contributor

@cieciurm cieciurm commented Jul 10, 2023

What this PR does / why we need it:
This PR revives #740

Which issue(s) this PR fixes:

Special notes for your reviewer:

  • Merged from master
  • Code updated
  • Tests updated
  • GitHub actions updated

Does this PR introduce a user-facing change?:

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

Dmytro Hridin and others added 30 commits April 14, 2022 00:40
…ghtsHealthCheck.cs

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…tionInsightsHealthCheckBuilderExtensions class
…plicationInsights.csproj

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…plicationInsights.csproj

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ureApplicationInsightsUnitTests.cs

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ureApplicationInsightsUnitTests.cs

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ureApplicationInsightsUnitTests.cs

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ureApplicationInsightsUnitTests.cs

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ureApplicationInsightsUnitTests.cs

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ureApplicationInsightsUnitTests.cs

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…AzureApplicationInsightsHealthCheckBuilderExtensions.cs

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…AzureApplicationInsightsHealthCheckBuilderExtensions.cs

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
@cieciurm cieciurm marked this pull request as ready for review July 10, 2023 14:37
@cieciurm
Copy link
Contributor Author

Hi @sungam3r,
It's ready for review.

@sungam3r sungam3r mentioned this pull request Jul 11, 2023
6 tasks
build/versions.props Outdated Show resolved Hide resolved
@sungam3r
Copy link
Collaborator

Please update root readme with new package.

@cieciurm
Copy link
Contributor Author

Oops, my bad. It's been updated now - cc @sungam3r

@codecov-commenter
Copy link

Codecov Report

Merging #1891 (9a8f4ed) into master (7dc61b4) will decrease coverage by 0.43%.
The diff coverage is 36.84%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1891      +/-   ##
==========================================
- Coverage   66.93%   66.50%   -0.43%     
==========================================
  Files         228      229       +1     
  Lines        8135     8097      -38     
  Branches      573      577       +4     
==========================================
- Hits         5445     5385      -60     
- Misses       2545     2568      +23     
+ Partials      145      144       -1     
Flag Coverage Δ
AzureApplicationInsights 14.79% <36.84%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...I/Core/HostedService/HealthCheckReportCollector.cs 65.60% <ø> (-0.19%) ⬇️
...ionInsights/AzureApplicationInsightsHealthCheck.cs 23.40% <23.40%> (ø)
...ApplicationInsightsHealthCheckBuilderExtensions.cs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@sungam3r sungam3r merged commit d0280f3 into Xabaril:master Jul 11, 2023
@cieciurm cieciurm deleted the feature/support-azure-insights branch July 11, 2023 11:07
@sungam3r
Copy link
Collaborator

I published preview version https://www.nuget.org/packages/AspNetCore.HealthChecks.AzureApplicationInsights/7.0.0-rc2.2.

Bad news - I accidentally published release version because of wrong tag in csproj, see 60cedfb.

@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure cosmosdb github_actions Pull requests that update Github_actions code test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants