-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive PR: Add Application Insights HealthCheck #1891
Revive PR: Add Application Insights HealthCheck #1891
Conversation
…and upgrade version number
…ghtsHealthCheck.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…tionInsightsHealthCheckBuilderExtensions class
…plicationInsights.csproj Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…plicationInsights.csproj Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ureApplicationInsightsUnitTests.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ureApplicationInsightsUnitTests.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ureApplicationInsightsUnitTests.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ureApplicationInsightsUnitTests.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ureApplicationInsightsUnitTests.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ureApplicationInsightsUnitTests.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…AzureApplicationInsightsHealthCheckBuilderExtensions.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…AzureApplicationInsightsHealthCheckBuilderExtensions.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ghtsHealthCheck.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
Hi @sungam3r, |
src/HealthChecks.AzureApplicationInsights/HealthChecks.AzureApplicationInsights.csproj
Show resolved
Hide resolved
src/HealthChecks.AzureApplicationInsights/AzureApplicationInsightsHealthCheck.cs
Outdated
Show resolved
Hide resolved
…ghtsHealthCheck.cs
src/HealthChecks.AzureApplicationInsights/AzureApplicationInsightsHealthCheck.cs
Outdated
Show resolved
Hide resolved
…ghtsHealthCheck.cs
src/HealthChecks.AzureApplicationInsights/AzureApplicationInsightsHealthCheck.cs
Outdated
Show resolved
Hide resolved
Please update root readme with new package. |
Oops, my bad. It's been updated now - cc @sungam3r |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1891 +/- ##
==========================================
- Coverage 66.93% 66.50% -0.43%
==========================================
Files 228 229 +1
Lines 8135 8097 -38
Branches 573 577 +4
==========================================
- Hits 5445 5385 -60
- Misses 2545 2568 +23
+ Partials 145 144 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I published preview version https://www.nuget.org/packages/AspNetCore.HealthChecks.AzureApplicationInsights/7.0.0-rc2.2. Bad news - I accidentally published release version because of wrong tag in csproj, see 60cedfb. |
What this PR does / why we need it:
This PR revives #740
Which issue(s) this PR fixes:
Special notes for your reviewer:
master
Does this PR introduce a user-facing change?:
Please make sure you've completed the relevant tasks for this PR, out of the following list: