Uniform conversion for all datetime. #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for delay on review this PR :-( .. I try to merge ASAP ( probably on Wednesday ) |
|
@unaizorrilla thx, that would be great. |
|
Hi @unaizorrilla |
|
I will merge this today |
|
Thx |
|
Thanks for your patience, already merged on master. |
|
thx. I have updated the package in our project. It did not solve the unknown data issue, so I will try to trace it. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi, thx for providing healthchecks code.
We have an error, only in our Docker/Rancher environment as this: 'Unknown Date' with no exception or details. This is not true json, witch have the side effect, that all logning is disgarded.
21.5.2019 14.03.13{"Timestamp":"2019-05-21T12:03:13.0745532+00:00","Level":"Information","MessageTemplate":"Executed DbCommand ({elapsed}ms) [Parameters=[{parameters}], CommandType='{commandType}', CommandTimeout='{commandTimeout}']{newLine}{commandText}","Properties":{"elapsed":"0","parameters":"@p1='?', @p0='?'","commandType":"Text","commandTimeout":30,"newLine":"\n","commandText":"UPDATE \"HealthCheckExecutionEntries\" SET \"Duration\" = @p0\nWHERE \"Id\" = @p1;\nSELECT changes();","EventId":{"Id":20101,"Name":"Microsoft.EntityFrameworkCore.Database.Command.CommandExecuted"},"SourceContext":"Microsoft.EntityFrameworkCore.Database.Command","Scope":["HealthReportCollector is collecting health checks results."]}} 21.5.2019 14.03.13{"Timestamp":"2019-05-21T12:03:13.0843973+00:00","Level":"Debug","MessageTemplate":"HealthReportCollector has completed.","Properties":{"SourceContext":"HealthChecks.UI.Core.HostedService.HealthCheckReportCollector","Scope":["HealthReportCollector is collecting health checks results."]}} 21.5.2019 14.03.13{"Timestamp":"2019-05-21T12:03:13.0844621+00:00","Level":"Debug","MessageTemplate":"HealthCheck collector HostedService executed successfully.","Properties":{"SourceContext":"HealthChecks.UI.Core.HostedService.HealthCheckCollectorHostedService"}} **Unknown Date**Since I dont know, what timezone our environment is using and sqlite dont have datetime.
We beleave that missing convertion for datetime i missing and may be the root of your error.
I have tryed to test the code, but have not had any success in doing that in our environment witch will include jenkins, push to docker, running in rancher.