Support for using OracleCredential with Oracle HealthCheck #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
sungam3r
reviewed
Jun 30, 2023
|
@moni-dips Thanks. I'm glad to merge after fixing API approval file. |
sungam3r
reviewed
Jun 30, 2023
test/HealthChecks.Oracle.Tests/Functional/OracleHealthCheckTests.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Jun 30, 2023
test/HealthChecks.Oracle.Tests/Functional/OracleHealthCheckTests.cs
Outdated
Show resolved
Hide resolved
|
Turns out I'd done a simple mixup when I set up the credential in the test. pushed a fix. |
|
API approval file left. |
sungam3r
approved these changes
Jul 3, 2023
|
@moni-dips Thanks. Will be published coming days in v7. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When using pooled connections with Oracle, it is necessary to use a singleton OracleCredential.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
It adds a new Credential property to OracleHealthCheckOptions
Please make sure you've completed the relevant tasks for this PR, out of the following list: