-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Use of Table Clients from IServiceProvider #1405
Merged
sungam3r
merged 9 commits into
Xabaril:master
from
wsugarman:users/wsugarman/table-serviceprovider
Aug 18, 2022
Merged
Allow Use of Table Clients from IServiceProvider #1405
sungam3r
merged 9 commits into
Xabaril:master
from
wsugarman:users/wsugarman/table-serviceprovider
Aug 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsugarman
commented
Aug 14, 2022
sungam3r
reviewed
Aug 15, 2022
sungam3r
reviewed
Aug 15, 2022
src/HealthChecks.CosmosDb/DependencyInjection/CosmosDbHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Aug 15, 2022
src/HealthChecks.CosmosDb/DependencyInjection/CosmosDbHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
This was referenced Aug 25, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds new health check registration overloads that reuse an existing client from the
IServiceProvider
instead of creating new ones. Includes the following changes:Which issue(s) this PR fixes: Relates to #1371
Relates to #1372
Does this PR introduce a user-facing change?: Yes. New APIs
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Sample