Add support for Basic Auth to ConsulHealthCheck #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @riker09 I try to review this ASAP, thanks for contributing! |
unaizorrilla
reviewed
Apr 4, 2019
|
Sounds like a good idea to enable BasicAuth explicitely. I will implement that next week. |
|
Hi @riker09 Merged, a release build is on appveyor, when finish a new nuget package 2.2.2 for Consul healthcheck will be available! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have read Don't push your pull request. I'm sorry if my PR offends any maintainer. You guys are doing great work.
But hopefully this change is so minimal, that it will not affect the greater scheme of things in any unexpected way.