Fix seq trailing slash, respect cancellation token, make SeqOptions.ApiKey nullable #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
reviewed
Jun 26, 2022
sungam3r
reviewed
Jun 26, 2022
test/HealthChecks.Publisher.Seq.Tests/Functional/SeqPublisherTests.cs
Outdated
Show resolved
Hide resolved
MrSmoke
commented
Jun 26, 2022
| @@ -6,7 +6,7 @@ public class SeqOptions | |||
| { | |||
| public string Endpoint { get; set; } = null!; | |||
|
|
|||
| public string ApiKey { get; set; } = null!; | |||
| public string? ApiKey { get; set; } | |||
There was a problem hiding this comment.
I had a look at the official API client for seq and it seems that the ApiKey can be null so it probably makes sense for it to be null here too?
https://github.com/datalust/seq-api/blob/dev/src/Seq.Api/Client/SeqApiClient.cs#L75=
sungam3r
reviewed
Jun 26, 2022
sungam3r
reviewed
Jun 26, 2022
| @@ -9,12 +9,11 @@ public void add_healthcheck_when_properly_configured() | |||
| services | |||
| .AddHealthChecks() | |||
| .AddSeqPublisher(setup => | |||
| new SeqOptions() | |||
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
sungam3r
approved these changes
Jun 27, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
SeqOptionsSeqOptions.ApiKeyis now nullable to handle cases where no api key is requiredseq_publisher_registration_should.add_healthcheck_when_properly_configuredoptions configured incorrectlyWhich issue(s) this PR fixes:
#1171
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
No
Please make sure you've completed the relevant tasks for this PR, out of the following list: