-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize UriHealthCheckOptions lazilly #120
Conversation
jnovick
commented
Mar 4, 2019
- Improves ability to test applications using the URI health check
- Improves ability to use NSwag client generators with URI health checks
* Improves ability to test applications using the URI health check * Improves ability to use NSwag client generators with URI health checks
Hi @jnovick Some tests are failing, can you check these errors? |
Yes, I will take a look. |
@jnovick, Any update on this? |
When I initially looked, I could not find anything wrong which frustrated me. I just looked again and got the tests running locally and they all pass. I merged master in and it seems to be fine with appveyor as well. I think the test failure before must have either been a fluke or unrelated. Thank you for your follow up reminder since i had forgotten about it. |
@unaizorrilla If you have a chance, please take a look. |
Appveyor fail sometimes when test external uri's!! I'm working on this PR right now! |
Merged, thanks @jnovick for contribute!!!! |