Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize UriHealthCheckOptions lazilly #120

Merged
merged 3 commits into from
May 2, 2019

Conversation

jnovick
Copy link
Contributor

@jnovick jnovick commented Mar 4, 2019

  • Improves ability to test applications using the URI health check
  • Improves ability to use NSwag client generators with URI health checks

* Improves ability to test applications using the URI health check
* Improves ability to use NSwag client generators with URI health checks
@unaizorrilla
Copy link
Collaborator

Hi @jnovick

Some tests are failing, can you check these errors?

@jnovick
Copy link
Contributor Author

jnovick commented Mar 4, 2019

Yes, I will take a look.

@CarlosLanderas
Copy link
Contributor

@jnovick, Any update on this?
Thanks!

@jnovick
Copy link
Contributor Author

jnovick commented Apr 19, 2019

When I initially looked, I could not find anything wrong which frustrated me. I just looked again and got the tests running locally and they all pass. I merged master in and it seems to be fine with appveyor as well. I think the test failure before must have either been a fluke or unrelated. Thank you for your follow up reminder since i had forgotten about it.

@jnovick
Copy link
Contributor Author

jnovick commented Apr 30, 2019

@unaizorrilla If you have a chance, please take a look.

@unaizorrilla
Copy link
Collaborator

When I initially looked, I could not find anything wrong which frustrated me. I just looked again and got the tests running locally and they all pass. I merged master in and it seems to be fine with appveyor as well. I think the test failure before must have either been a fluke or unrelated. Thank you for your follow up reminder since i had forgotten about it.

Appveyor fail sometimes when test external uri's!! I'm working on this PR right now!

@unaizorrilla unaizorrilla merged commit 2a2e259 into Xabaril:master May 2, 2019
@unaizorrilla
Copy link
Collaborator

Merged, thanks @jnovick for contribute!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants