Aws secrets manager #1126
Merged
Aws secrets manager #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please resolve conflicts. |
sungam3r
reviewed
May 2, 2022
src/HealthChecks.Aws.SecretsManager/HealthChecks.Aws.SecretsManager.csproj
Outdated
Show resolved
Hide resolved
…nager.csproj Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
|
Bad conflict merge resolution .Will look over again later. Thanks. |
sungam3r
reviewed
May 7, 2022
sungam3r
reviewed
May 7, 2022
sungam3r
reviewed
May 7, 2022
sungam3r
reviewed
May 7, 2022
sungam3r
reviewed
May 7, 2022
sungam3r
reviewed
May 7, 2022
sungam3r
reviewed
May 7, 2022
sungam3r
reviewed
May 7, 2022
src/HealthChecks.Aws.SecretsManager/SecretsManagerHealthCheck.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
May 7, 2022
src/HealthChecks.Aws.SecretsManager/SecretsManagerHealthCheck.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
May 7, 2022
sungam3r
reviewed
May 7, 2022
…Async for CheckSecretAsync
sungam3r
reviewed
May 25, 2022
test/HealthChecks.Aws.SecretsManager.Tests/DependencyInjection/RegistrationTests.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
May 25, 2022
sungam3r
reviewed
May 25, 2022
sungam3r
reviewed
May 25, 2022
sungam3r
reviewed
May 25, 2022
sungam3r
reviewed
May 25, 2022
...hChecks.Aws.SecretsManager/DependencyInjection/SecretsManagerHealthCheckBuilderExtensions.cs
Show resolved
Hide resolved
sungam3r
reviewed
May 25, 2022
|
I added some minor fixes here as well as in #1128. |
added 4 commits
May 25, 2022 17:34
…ile scope namespace. Simpilified Secrets member.
sungam3r
reviewed
May 27, 2022
test/HealthChecks.Aws.SecretsManager.Tests/DependencyInjection/RegistrationTests.cs
Show resolved
Hide resolved
…/RegistrationTests.cs
sungam3r
reviewed
May 27, 2022
src/HealthChecks.Aws.SecretsManager/SecretsManagerHealthCheck.cs
Outdated
Show resolved
Hide resolved
|
@zodraz Add |
|
Thanks to you @sungam3r. I realized I did not update the main Readmemd file. Was that necessary? Or it follows some life cycle acceptance publishing the proper nuget and make available to the public? |
|
I forgot about that. You may do it in new PR. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support for Healtchecks on AWS Secrets Manager.
Which issue(s) this PR fixes:
Please reference the issue this PR will close: #1125
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?:
No since it is a brand new HealthCheck project
Please make sure you've completed the relevant tasks for this PR, out of the following list: