fix(ui-checktable): solves problem with misaligned tags #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50f3125 to
17e31ae
Compare
carlosrecuero
approved these changes
Apr 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR solves the problem with misaligned tags for some font families/sizes. Moreover, CheckTable component is refactored (favoring immutability, types over interfaces, removing unnecesary typing like FunctionComponent and improving naming)
Which issue(s) this PR fixes:
#887
Does this PR introduce a user-facing change?: Yes
Please make sure you've completed the relevant tasks for this PR, out of the following list: