Bumping apiVersion for healtchecks crd definition

[tcinbis]

What this PR does / why we need it:

When deploying the healthchecks operator on the latest version of kind it will fail, because apiextensions.k8s.io/v1beta1 is not supported any longer.
This bumps the apiVersion to the stable version and adds minimal changes to adhere to the specification.

Which issue(s) this PR fixes:

Fixes #723

Special notes for your reviewer: -

Does this PR introduce a user-facing change?: No

[carlosrecuero]

Some potential problems to consider:

• because of the fact that this piece is not versioned, this will break for everyone that was using the previous version and has an old kubernetes version --> My proposal is to rename the previous version for them and add a quick comment on the readme.
• check that the operator executable is taking the new version and, if required, create a new version of it.

[tcinbis]

Hey @carlosrecuero,

Thanks for the feedback! I have two clarification questions before I go and add more changes.

1. With renaming you suggest adding an old copy of the deploy/operator/crd/healthcheck-crd.yaml under a different name (e.g. deploy/operator/crd/healthcheck-crd-pre-v1.22.yaml)?
2. We are only applying the YAML files are not using the installer. Could you or someone else take on the testing of it? :)

Thanks!

[carlosrecuero]

Hey @carlosrecuero,

Thanks for the feedback! I have two clarification questions before I go and add more changes.

1. With renaming you suggest adding an old copy of the deploy/operator/crd/healthcheck-crd.yaml under a different name (e.g. deploy/operator/crd/healthcheck-crd-pre-v1.22.yaml)?
2. We are only applying the YAML files are not using the installer. Could you or someone else take on the testing of it? :)

Thanks!

1. Ok
2. Let's split it, it is ok.

[tcinbis]

Hey @carlosrecuero and @sungam3r !
I added the pre v1.22 version of the CRD to the PR. I think from my side we are ready to go.
What do you think? :)

[sungam3r]

I do not use/understand this part of project, waiting for @carlosrecuero .

[carlosrecuero]

Sorry for the delay. Approved.

[tcinbis]

Awesome thanks! I can’t merge since I am missing write access, so I guess someone of you will press the button? :)