extended rabbitMq health check with tls option. #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hansehe The changes contains new parameter on RabbitMQHealthCheck but the extension method for registering the health check don't use this new parameter. How the user can set the SSL option when the healthcheck is registered? Also, increment the version for this package on dependencies.props |
|
Hi @hansehe Can you address the changes for this PR? |
update from fork master
738c4c1 to
c4aa201
Compare
|
Hi, and I'm sorry for being so slow to reply. I missed the extensions class and the version update, but it should all be fine now. Please have a look at the update, and tell me if something should be changed. |
|
Thanks @hansehe for contribute this, merged and release build enqueued, when finish a new packages version (2.2.1) will be on nuget. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rabbitMq health check was missing tls option, thus it would be useless in many cases where tls with rabbitMq is enabled.