Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring Elastic Timeout #317

Closed
cypressious opened this issue Oct 31, 2019 · 2 comments
Closed

Allow configuring Elastic Timeout #317

cypressious opened this issue Oct 31, 2019 · 2 comments

Comments

@cypressious
Copy link

The Elastic client allows configuring request timeouts via ConnectionSettings.RequestTimeout, however this is not exposed in AspNetCore.HealthChecks.Elasticsearch.

Consider adding a way to configure the timeout.

@unaizorrilla
Copy link
Collaborator

PR welcome ! :-)

@inkel
Copy link
Contributor

inkel commented Nov 14, 2019

I'm happy to send a PR for this, however, I've got a couple of questions:

Both current extensions IHealthChecksBuilder.AddElasticsearch accept an optional, last parameter TimeSpan? timeout = default. Now, according to the documentation, this parameter is An optional System.TimeSpan representing the timeout of the check.

My question would be: should we use that value too and pass it to ElasticsearchOptions or should we add a new one TimeSpan? requestTimeout = default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants