Skip to content
This repository was archived by the owner on May 13, 2022. It is now read-only.

Updating with changes required for camera system updates #42

Merged
merged 4 commits into from
Nov 9, 2019
Merged

Updating with changes required for camera system updates #42

merged 4 commits into from
Nov 9, 2019

Conversation

SimonDarksideJ
Copy link
Contributor

@SimonDarksideJ SimonDarksideJ commented Oct 23, 2019 •
edited by StephenHodgson
Loading

Overview

Updating with changes required forhttps://github.com/XRTK/com.xrtk.core/pull/386

Changes:

@SimonDarksideJ SimonDarksideJ self-assigned this Oct 23, 2019
StephenHodgson
StephenHodgson suggested changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@StephenHodgson StephenHodgson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should have been bundled with the other pull request

@SimonDarksideJ
Copy link
Contributor Author

What other PR, this is for the WMR package

@StephenHodgson StephenHodgson changed the title Updating with changes required for Core\#386 Updating with changes required for camera system updates Oct 23, 2019
@StephenHodgson
Copy link
Contributor

XRTK/com.xrtk.core#386

I've went ahead and updated that PR with this branch checkout to be included :)

@StephenHodgson StephenHodgson self-requested a review October 23, 2019 14:22
@StephenHodgson StephenHodgson self-requested a review October 23, 2019 17:17
StephenHodgson
StephenHodgson suggested changes Nov 3, 2019
View reviewed changes
Copy link
Contributor

@StephenHodgson StephenHodgson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@StephenHodgson StephenHodgson merged commit 9d08cb4 into master Nov 9, 2019
@StephenHodgson StephenHodgson deleted the camera_system_updates branch November 9, 2019 14:09
StephenHodgson added a commit that referenced this pull request Nov 9, 2019
@StephenHodgson
Revert "Updating with changes required for camera system updates (#42)"
7b65756 
This reverts commit 9d08cb4.
@StephenHodgson StephenHodgson mentioned this pull request Nov 9, 2019
Closed
@StephenHodgson StephenHodgson restored the camera_system_updates branch November 9, 2019 14:10
@StephenHodgson
Copy link
Contributor

I realized this went to master. We gotta be more aware of the branch we're targeting with our pull requests

@StephenHodgson StephenHodgson mentioned this pull request Nov 9, 2019
Merged
@StephenHodgson StephenHodgson deleted the camera_system_updates branch November 9, 2019 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephenHodgson StephenHodgson StephenHodgson approved these changes

Assignees

@SimonDarksideJ SimonDarksideJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonDarksideJ @StephenHodgson