This repository has been archived by the owner on May 13, 2022. It is now read-only.
Remove glTF loading from WMR package #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FejZa
previously approved these changes
Mar 30, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hmm, will look in to the bug raised by the build, but curious why is didn't show up in my local builds. |
|
Let's open a new issue to recreate the glTF visualizer once the glTF package is published. We can go ahead and get this merged in and a release made for this change tho. Just needs the updated reference to the core preview package |
StephenHodgson
approved these changes
Apr 11, 2021
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Apr 13, 2021
* Remove glTF loading from WMR package Supports: XRTK/com.xrtk.core#801 * Uplifted Core version dependency * updated package dependencies * updated gitignore Co-authored-by: Stephen Hodgson <hodgson.designs@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
Remove glTF loading from WMR package
Supports: XRTK/com.xrtk.core#801
for glTF loading on WMR, a custom Visualizer would be needed to load the platform or custom glTF model