This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Fix auto scene switcher dialog appearing when toolkit is already active and configured #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
SimonDarksideJ
approved these changes
Jan 13, 2021
StephenHodgson
approved these changes
Jan 13, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Jan 15, 2021
Co-authored-by: Stephen Hodgson <hodgson.designs@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
This PR fixes the
AutoSceneSwitchershowing up when the toolkit is actually already configured in the scene(s).Also this fixes the
AutoSceneSwitcherforcing the XRTK base scene to be the active scene. This breaks multi-scene editing behaviour expected from the editor. As only the active scene's lightmaps will be used and people might want another scene to be the active scene in editor. The XRTK does not require the base scene to be the active scene, it just needs to be loaded.