Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Misc bug fixes for 0.2.0 release #710

Merged
merged 6 commits into from
Dec 14, 2020

Conversation

StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented Dec 13, 2020

XRTK - Mixed Reality Toolkit Pull Request

Overview

General fixes to installation and configuration.

Updated guid regeneration for package installation. Added a guid map in the XRTK.Generated folder that stores the regenerated guids and the mapping to the original guid.

Changes

cleaned up package installation
updated profile property drawer
@StephenHodgson StephenHodgson added the Ready for review PR finished primary development, open for review label Dec 13, 2020
SimonDarksideJ
SimonDarksideJ previously approved these changes Dec 13, 2020
Copy link
Contributor

@SimonDarksideJ SimonDarksideJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, real test will be with upm package deployment

@StephenHodgson
Copy link
Contributor Author

Tested locally by installing as a local embedded package, but yeah that's the true test

…none are found

Fixed invalid namespaces in collider and collision extensions
@StephenHodgson StephenHodgson changed the title Updated guid regeneration for package installation Misc bug fixes for 0.2.0 release Dec 13, 2020
@StephenHodgson StephenHodgson merged commit 88edf37 into development Dec 14, 2020
@StephenHodgson StephenHodgson deleted the fix/package-guid-regeneration branch December 14, 2020 11:49
XRTK-Build-Bot pushed a commit that referenced this pull request Dec 25, 2020
* updated guid regeneration to save the map of regenerated guids

cleaned up package installation
updated profile property drawer

* use key and value for field names

* Added Implementation validation check that prompts to install SDK if none are found

Fixed invalid namespaces in collider and collision extensions

* Don't update submodules if they don't exist

* cleaned up using statements

formatting
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ready for review PR finished primary development, open for review
Projects
None yet
2 participants