This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleaned up package installation updated profile property drawer
StephenHodgson
added
the
Ready for review
PR finished primary development, open for review
label
Dec 13, 2020
SimonDarksideJ
previously approved these changes
Dec 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, real test will be with upm package deployment
Tested locally by installing as a local embedded package, but yeah that's the true test |
…none are found Fixed invalid namespaces in collider and collision extensions
StephenHodgson
changed the title
Updated guid regeneration for package installation
Misc bug fixes for 0.2.0 release
Dec 13, 2020
SimonDarksideJ
approved these changes
Dec 14, 2020
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* updated guid regeneration to save the map of regenerated guids cleaned up package installation updated profile property drawer * use key and value for field names * Added Implementation validation check that prompts to install SDK if none are found Fixed invalid namespaces in collider and collision extensions * Don't update submodules if they don't exist * cleaned up using statements formatting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
General fixes to installation and configuration.
Updated guid regeneration for package installation. Added a guid map in the XRTK.Generated folder that stores the regenerated guids and the mapping to the original guid.
Changes