This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Fixing gltf serialization #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenHodgson
approved these changes
Nov 10, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* Initial import of Serialization improvements * Code review and fix * bugfix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
Ported fix from MRTK, where it was noted there were serialisation issues with the gLTF importer when using the Unity JsonUtility
Changes
Mainly enums have been updated to use the ISerializationCallbackReceiver with a Serialization text field and the internal enum
Tested and noted the changes did improve serilization