Only apply default head height if not managed by device

[FejZa]

XRTK - Mixed Reality Toolkit Pull Request

Overview

Introduced

/// <summary>
/// Is the head height, and thus the camera y-position, managed by the device itself?
/// If true, the <see cref="DefaultHeadHeight"/> setting is ignored and has no effect
/// on camera positioning.
/// </summary>
bool HeadHeightIsManagedByDevice { get; }

to IMixedRealityCameraDataProvider and implemented as

/// <inheritdoc />
public virtual bool HeadHeightIsManagedByDevice => XRDevice.isPresent;

in BaseCameraDataProvider

to only apply the DefaultHeadHeight setting, if the device does not manage head height itself, which is the case
with many devices, like HoloLens e.g.

By default we will assume as soon as an XR Device is connected that it manages head height, since most devices these days will do. The developer has the option to override the default value per platform.

Changes

• Fixes: DefaultHeadHeight setting in camera data provider profile causes misbehaviour #656

[FejZa]

@SimonDarksideJ I tested this and it did resolve the issues I had. Ready for review.

[StephenHodgson]

I'm fine with these changes but I'm not sure if we need to update and validate the other platforms that bypass the XR Subsystems that need to also check if the device is present.

[FejZa]

True, I'll double check the platform overrides.

[SimonDarksideJ]

Approved, tested on WMR, Oculus and OpenVR. Hands now appear correctly on all these platforms.