Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Dev/more ci updates #639

Merged
merged 16 commits into from
Jun 10, 2020
Merged

Dev/more ci updates #639

merged 16 commits into from
Jun 10, 2020

Conversation

StephenHodgson
Copy link
Contributor

XRTK - Mixed Reality Toolkit Pull Request

Overview

More build pipeline updates

@StephenHodgson StephenHodgson added the In Progress PR currently still being developed label Jun 9, 2020
@StephenHodgson StephenHodgson added Ready for review PR finished primary development, open for review and removed In Progress PR currently still being developed labels Jun 10, 2020
@StephenHodgson StephenHodgson marked this pull request as ready for review June 10, 2020 04:16
Copy link
Contributor

@FejZa FejZa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this works. There is actually a log file which can be streamed to the DevOps console to get logs. But this approach is interesting as well.

@StephenHodgson
Copy link
Contributor Author

I mean that works too, but I figured since we're already getting the console output why hide it? I don't like that it essentially duplicates the logs, but I do like that we can get faster feedback in the reports in GitHub itself

@StephenHodgson StephenHodgson merged commit f642d80 into development Jun 10, 2020
@StephenHodgson StephenHodgson deleted the dev/more-ci-updates branch June 10, 2020 18:15
XRTK-Build-Bot pushed a commit that referenced this pull request Dec 25, 2020
* a bit more polish to the pipeline

* sync upm packge info file with the template

* test macOS builds

* Removed stage name

* remove dep

* test logging utility

* ignored some logs and removed exception for regular logging bc of switch

* updated submodules

* disable logging in tests

* updated submodules

* fixed logs

* updated ultraleap checkout

* authenticate to get github api access

add secure connection

* fix warning vso logging

* removed the mac build

* updated ultraleap checkout
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ready for review PR finished primary development, open for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants