This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add secure connection
StephenHodgson
added
Ready for review
PR finished primary development, open for review
and removed
In Progress
PR currently still being developed
labels
Jun 10, 2020
FejZa
approved these changes
Jun 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this works. There is actually a log file which can be streamed to the DevOps console to get logs. But this approach is interesting as well.
I mean that works too, but I figured since we're already getting the console output why hide it? I don't like that it essentially duplicates the logs, but I do like that we can get faster feedback in the reports in GitHub itself |
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* a bit more polish to the pipeline * sync upm packge info file with the template * test macOS builds * Removed stage name * remove dep * test logging utility * ignored some logs and removed exception for regular logging bc of switch * updated submodules * disable logging in tests * updated submodules * fixed logs * updated ultraleap checkout * authenticate to get github api access add secure connection * fix warning vso logging * removed the mac build * updated ultraleap checkout
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
More build pipeline updates