This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Disabled package installation button in xrtk.core project #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FejZa
approved these changes
May 4, 2020
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* Disabled package installation button in xrtk.core project * close the window if packages is empty and log a warning
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
Because
Mixed Reality Toolkit/List Packagesmenu is a part of the seed it's availible in the xrtk.core project, but we don't want people to install the packages as they're already referenced as submodules.To prevent this I added a simple XRTK key to check if the editor prefs has an XRTK key and disables the
Add selected packagesbutton to prevent its self destruction in the core project itself.