This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 34
Feature/move prefabs to hidden folder #563
Merged
StephenHodgson
merged 6 commits into
development
from
feature/move-prefabs-to-hidden-folder
May 4, 2020
Merged
Feature/move prefabs to hidden folder #563
StephenHodgson
merged 6 commits into
development
from
feature/move-prefabs-to-hidden-folder
May 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenHodgson
added
Enhancement
New feature or request
Blocked
Ready for review
PR finished primary development, open for review
labels
May 4, 2020
StephenHodgson
changed the base branch from
development
to
feature/profile-guid-regeneration
May 4, 2020 02:01
FejZa
previously approved these changes
May 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. This will also make working with render pipelines much easier.
I am just wondering as to why there is baked lighting assets and reflection probes for the base scene, which only contains the service locator and the playspace.
Idk it was already baked in. We can always change this later I suppose. No big deal |
SimonDarksideJ
previously approved these changes
May 4, 2020
StephenHodgson
changed the base branch from
feature/profile-guid-regeneration
to
development
May 4, 2020 12:34
StephenHodgson
dismissed stale reviews from SimonDarksideJ and FejZa
May 4, 2020 12:34
The base branch was changed.
# Conflicts: # Submodules/SDK
FejZa
previously approved these changes
May 4, 2020
SimonDarksideJ
approved these changes
May 4, 2020
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* Added guid regeneration for installed package profiles to prevent asset collisions * get full path to destination folder for guid regeneration * catch null instance type references and log it * moved sdk prefabs from package to hidden path * updated sdk checkout
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Enhancement
New feature or request
Ready for review
PR finished primary development, open for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
Moved all of the SDK prefabs into a hidden
Prefabs~
folder to be copied and installed the same way profiles are.Submodule Changes