Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Feature/move prefabs to hidden folder #563

Merged
merged 6 commits into from
May 4, 2020

Conversation

StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented May 4, 2020

XRTK - Mixed Reality Toolkit Change Request

Overview

Moved all of the SDK prefabs into a hidden Prefabs~ folder to be copied and installed the same way profiles are.

Submodule Changes

@StephenHodgson StephenHodgson added Enhancement New feature or request Blocked Ready for review PR finished primary development, open for review labels May 4, 2020
@StephenHodgson StephenHodgson changed the base branch from development to feature/profile-guid-regeneration May 4, 2020 02:01
@StephenHodgson StephenHodgson mentioned this pull request May 4, 2020
36 tasks
FejZa
FejZa previously approved these changes May 4, 2020
Copy link
Contributor

@FejZa FejZa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. This will also make working with render pipelines much easier.
I am just wondering as to why there is baked lighting assets and reflection probes for the base scene, which only contains the service locator and the playspace.

@StephenHodgson
Copy link
Contributor Author

Idk it was already baked in. We can always change this later I suppose. No big deal

SimonDarksideJ
SimonDarksideJ previously approved these changes May 4, 2020
@StephenHodgson StephenHodgson changed the base branch from feature/profile-guid-regeneration to development May 4, 2020 12:34
@StephenHodgson StephenHodgson dismissed stale reviews from SimonDarksideJ and FejZa May 4, 2020 12:34

The base branch was changed.

FejZa
FejZa previously approved these changes May 4, 2020
@StephenHodgson StephenHodgson merged commit 5d40ca1 into development May 4, 2020
@StephenHodgson StephenHodgson deleted the feature/move-prefabs-to-hidden-folder branch May 4, 2020 13:07
XRTK-Build-Bot pushed a commit that referenced this pull request Dec 25, 2020
* Added guid regeneration for installed package profiles to prevent asset collisions

* get full path to destination folder for guid regeneration

* catch null instance type references and log it

* moved sdk prefabs from package to hidden path

* updated sdk checkout
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement New feature or request Ready for review PR finished primary development, open for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants