This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Added guid regeneration for installed package profiles to prevent asset collisions #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this also solve the issue of asset referencing when the profiles are copied? |
|
Yes, that's the whole point |
SimonDarksideJ
approved these changes
May 4, 2020
FejZa
approved these changes
May 4, 2020
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
…et collisions (#562) * Added guid regeneration for installed package profiles to prevent asset collisions * get full path to destination folder for guid regeneration * catch null instance type references and log it Co-authored-by: Dino Fejzagic <dino.f@live.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
To prevent asset collisions and problems when copying prefabs and profiles, I thought it'd be best to regenerate any guid references in the copied assets.