This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Ensure that the detected input sources and detected controller's are readonly from the system #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…readonly from the system
SimonDarksideJ
approved these changes
Mar 31, 2020
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Apr 1, 2020
…readonly from the system (#481)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
Collections from any
IMixedRealityServiceinterface should only return readonly values.Breaking changes
IMixedRealityInputSystem.DetectedInputSourcesis now aIReadOnlyCollection<IMixedRealityInputSource>IMixedRealityInputSystem.DetectedControllersis now aIReadOnlyCollection<IMixedRealityController>If anyone was adding to these collections before they should use the proper method via:
IMixedRealityInputSystem.RaiseSourceDetected(IMixedRealityInputSource source, IMixedRealityController controller = null)IMixedRealityInputSystem.RaiseSourceLost(IMixedRealityInputSource source, IMixedRealityController controller = null)respectively.