This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
New array Extension plus tests #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… array to a new value, including Tests * Added null check on Array AddItem Fixed license in Core test 2
SimonDarksideJ
added a commit
that referenced
this pull request
Mar 9, 2020
… initialised Requires #461
Co-Authored-By: Stephen Hodgson <StephenHodgson@users.noreply.github.com>
|
Applied suggested fix to both extensions, if the array is null, return a single item array with the item provided |
2 tasks
StephenHodgson
approved these changes
Mar 10, 2020
StephenHodgson
added a commit
that referenced
this pull request
Mar 16, 2020
* * Added new "InitialiseArray" array extension to set all values of an array to a new value, including Tests * Added null check on Array AddItem Fixed license in Core test 2 * Resolved a new issue for when a new controller is defined but not yet initialised Requires #461 * Forgot to turn wysiwyg off again :D Co-authored-by: Stephen Hodgson <StephenHodgson@users.noreply.github.com>
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Mar 27, 2020
* * Added new "InitialiseArray" array extension to set all values of an array to a new value, including Tests * Added null check on Array AddItem Fixed license in Core test 2 * Update XRTK-Core/Packages/com.xrtk.core/Extensions/ArrayExtensions.cs Co-Authored-By: Stephen Hodgson <StephenHodgson@users.noreply.github.com> * Applied review patches Co-authored-by: Stephen Hodgson <StephenHodgson@users.noreply.github.com>
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Mar 27, 2020
* * Added new "InitialiseArray" array extension to set all values of an array to a new value, including Tests * Added null check on Array AddItem Fixed license in Core test 2 * Resolved a new issue for when a new controller is defined but not yet initialised Requires #461 * Forgot to turn wysiwyg off again :D Co-authored-by: Stephen Hodgson <StephenHodgson@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview