This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Configuration data structure refactor #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfiguration structs into a single type and a pre-step to consolidating the editor inspector codes for drawing/displaying this list in the editor.
Finally got to refactor the MixedRealityToolkit to finally utilize configurations for service registration
…nfiguration fixed unit tests
|
Oh wait, this is still in progress. I need to update the inspectors still. |
2 tasks
…n-refactor # Conflicts: # XRTK-Core/Packages/com.xrtk.core/Inspectors/Profiles/InputSystem/MixedRealityControllerDataProvidersProfileInspector.cs
|
Is this yet ready or is it pending the other PR? |
|
Just need to finish up fixing the inspectors |
|
Inspectors should be done. Only thing left is getting the dropdown filtering working properly again but we can do that later. |
|
Not critical since this is due to be refactored, but Input Action Rules config has stopped working, the dropdowns don't work, not sure if it's related to this change |
SimonDarksideJ
approved these changes
Mar 1, 2020
There was a problem hiding this comment.
Looks good, and tests well.
Only areas that the type lookup doesn't work are:
- Controller Mapping type
- Spatial Observer type
- Networking type (although this inspector doesn't seems to have a custom inspector)
- Diagnostics type
- Registered Service Providers
Everywhere else the type dropdowns work as expected
StephenHodgson
added a commit
that referenced
this pull request
Mar 27, 2020
* Introduced IBaseMixedRealityServiceConfiguration This interface is meant to be used with serialized structs that define valid IMixedRealityService configurations * added IMixedRealityServiceConfiguration updated the implementations of all the existing configurations * Updated all the configurations to use Name instead of their one off property type prefixed names * reverted a field rename in MixedRealityExtensionServiceConfiguration updated a few references * some fixes from the last pr merge * Refactored BaseMixedRealityProfile a bit Renamed IsCustomProfile to IsDefaultProfile * A bit more refactoring to generic types Added a base mixed reality service profile to better distinguish between service configuration profiles and other generic base types * updated WMR package * updated all the icons * Configuration data structure refactor (#458) * renamed the serialized backing fields so we can consolidate all the configuration structs into a single type and a pre-step to consolidating the editor inspector codes for drawing/displaying this list in the editor. * updated usages of the IMixedRealityServiceConfiguarion arrays * Much closer to the final result. Finally got to refactor the MixedRealityToolkit to finally utilize configurations for service registration * revert * Fixed some issues with casting the interface for the mixed reality configuration fixed unit tests * fixed some icons and licenses * fixed some merge issues * reverted a change * use the proper base property for Configurations * updated all the inspectors to use the most updated version of the list * fixed filtering * fixed filtering * added documentation and a bit of optimization around strings * added some documentation and disabled a warning about an unused type parameter * Added more documentation about how to define and filter instanced types in the service configuration dropdown * removed unused extension * removed the base mixed reality service configuration * added missing reference * fixed wmr checkout
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Mar 27, 2020
* Introduced IBaseMixedRealityServiceConfiguration This interface is meant to be used with serialized structs that define valid IMixedRealityService configurations * added IMixedRealityServiceConfiguration updated the implementations of all the existing configurations * Updated all the configurations to use Name instead of their one off property type prefixed names * reverted a field rename in MixedRealityExtensionServiceConfiguration updated a few references * some fixes from the last pr merge * Refactored BaseMixedRealityProfile a bit Renamed IsCustomProfile to IsDefaultProfile * A bit more refactoring to generic types Added a base mixed reality service profile to better distinguish between service configuration profiles and other generic base types * updated WMR package * updated all the icons * Configuration data structure refactor (#458) * renamed the serialized backing fields so we can consolidate all the configuration structs into a single type and a pre-step to consolidating the editor inspector codes for drawing/displaying this list in the editor. * updated usages of the IMixedRealityServiceConfiguarion arrays * Much closer to the final result. Finally got to refactor the MixedRealityToolkit to finally utilize configurations for service registration * revert * Fixed some issues with casting the interface for the mixed reality configuration fixed unit tests * fixed some icons and licenses * fixed some merge issues * reverted a change * use the proper base property for Configurations * updated all the inspectors to use the most updated version of the list * fixed filtering * fixed filtering * added documentation and a bit of optimization around strings * added some documentation and disabled a warning about an unused type parameter * Added more documentation about how to define and filter instanced types in the service configuration dropdown * removed unused extension * removed the base mixed reality service configuration * added missing reference * fixed wmr checkout
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
A pre-step to consolidating the editor inspector codes for drawing/displaying this list in the editor.
Target of the change:
Is this enhancement for:
Changes:
Breaking Changes:
BaseMixedRealityProfile.IsCustomProfiletoIsEditable