Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Dev/pointer dragging events #382

Merged
merged 7 commits into from
Oct 9, 2019
Merged

Conversation

StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented Oct 9, 2019

XRTK - Mixed Reality Toolkit Change Request

Overview

Adds pointer drag events to the XRTK and ensure's they are properly forwarding events to the uGUI elements if they're being used.

Target of the change:

Is this enhancement for:

  • Core (core framework, interfaces and definitions)

Breaking Changes:

Are there any breaking changes included in this change that would prevent or cause issue for existing projects.

  • MixedRealityPointerEventData.Count was removed, and will be replaced in the upcoming input action refactor work to address Enable XRTK to provide by default, support for Long press and double click #258.
  • Adds MixedRealityPointerScrollEventData
  • Adds IMixedRealityPointerScrollHandler
  • Adds MixedRealityPointerDragEventData
  • Adds IMixedRealityPointerDragHandler
  • Updated the IMixedRealityInputSystem:
    • RaisePointerDragBegin
    • RaisePointerDrag
    • RaisePointerDragEnd
    • RaisePointerClicked removed the count int parameter
    • RaisePointerScroll now properly initialized event data for its event type

@StephenHodgson StephenHodgson added Enhancement New feature or request Breaking Change labels Oct 9, 2019
@StephenHodgson StephenHodgson added the In Progress PR currently still being developed label Oct 9, 2019
@StephenHodgson StephenHodgson added Ready for review PR finished primary development, open for review In Progress PR currently still being developed and removed In Progress PR currently still being developed Ready for review PR finished primary development, open for review labels Oct 9, 2019
@StephenHodgson StephenHodgson added Ready for review PR finished primary development, open for review and removed In Progress PR currently still being developed labels Oct 9, 2019
@StephenHodgson StephenHodgson merged commit f6354f1 into development Oct 9, 2019
@StephenHodgson StephenHodgson deleted the dev/pointer-dragging-events branch October 9, 2019 17:53
@StephenHodgson StephenHodgson mentioned this pull request Oct 9, 2019
XRTK-Build-Bot pushed a commit that referenced this pull request Oct 9, 2019
* first pass at pointer drag events

* updated SDK checkout

* Updated icons for new files

* Make sure we're setting the graphic input event data correctly.

* updated package information and SDK checkout

* updated the events to use the proper pointer drag event data

* Added proper support for scroll handler
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Breaking Change Enhancement New feature or request Ready for review PR finished primary development, open for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants