This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Cleaned up controller data providers #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apping extension Updated Base Controller/Provider patterns to use a more efficient ActiveControllers property Updated OpenVR Interaction Mapping use to new singular model
Removed old InteractionMapping Extensions
This was referenced Sep 29, 2019
StephenHodgson
approved these changes
Sep 29, 2019
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Sep 30, 2019
* Update to Base Controller framework to use newer Single Interaction Mapping extension Updated Base Controller/Provider patterns to use a more efficient ActiveControllers property Updated OpenVR Interaction Mapping use to new singular model * **Breaking change** Removed old InteractionMapping Extensions * updated submodules
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
Update OpenVR platform to use new Interactions Mapping Extension
Target of the change:
Is this enhancement for:
Changes:
Breaking Changes:
Changes to the Controller interfaces will break the other platforms, update required
IMixedRealityControllerDataProvider.GetActiveControllers()was replaced withIMixedRealityControllerDataProvider.ActiveControllersIMixedRealityInteractionMappingExtensionswas consolidated into a single method call.Additional notes
Changes extracted from @StephenHodgson PR for InputActions #358