This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Dev/editor platform flag #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Submodules/SDK
FejZa
approved these changes
Sep 15, 2019
| GltfObject gltfObject = null; | ||
|
|
||
| // If a specific controller template exists, check if it wants to override the global model, or use the system default specifically (in case global default is not used) | ||
| bool useSystemDefaultModels = visualizationProfile.GetControllerModelOverride(controllerType, ControllerHandedness, out controllerModel); | ||
| bool useSystemDefaultModels = visualizationProfile.GetControllerModelOverride(controllerType, ControllerHandedness, out var controllerModel); |
There was a problem hiding this comment.
Not a fan of var here but I guess that's personal preference.
There was a problem hiding this comment.
Just a product of in-lining the out variable. I don't really mind, more concise.
SimonDarksideJ
approved these changes
Sep 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
Added editor platform flag to the supported platform enum to specify editor only services
Target of the change:
Is this enhancement for:
Breaking Changes:
Are there any breaking changes included in this change that would prevent or cause issue for existing projects.
Editorflag to run in the editor by default, and update their platforms.