Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Ported extension changes from pointer offset #314

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Ported extension changes from pointer offset #314

merged 2 commits into from
Sep 12, 2019

Conversation

StephenHodgson
Copy link
Contributor

XRTK - Mixed Reality Toolkit Change Request

Overview

Moved a bunch of vector maths and reusable code into the appropriate extension classes

Target of the change:

Is this enhancement for:

  • Core (core framework, interfaces and definitions)
  • Extensions

@StephenHodgson StephenHodgson added Enhancement New feature or request Ready for review PR finished primary development, open for review labels Sep 10, 2019
SimonDarksideJ
SimonDarksideJ approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@SimonDarksideJ SimonDarksideJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see more Unit Tests on this, but we can do that in another pass

@StephenHodgson StephenHodgson merged commit 4ec27a3 into development Sep 12, 2019
@StephenHodgson StephenHodgson deleted the dev/extensions branch September 12, 2019 12:42
XRTK-Build-Bot pushed a commit that referenced this pull request Sep 13, 2019
@StephenHodgson
Ported extension changes from pointer offset (#314)
d05d79d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimonDarksideJ SimonDarksideJ SimonDarksideJ approved these changes

Assignees
No one assigned
Labels
Enhancement New feature or request Ready for review PR finished primary development, open for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StephenHodgson @SimonDarksideJ