Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Added checks for editor updating #313

Merged
merged 4 commits into from
Sep 12, 2019

Conversation

StephenHodgson
Copy link
Contributor

XRTK - Mixed Reality Toolkit Change Request

Overview

Added more checks to see if the editor is already attempting to update to try and mitigate a warning seen during initial import.

Target of the change:

Is this enhancement for:

  • Core (core framework, interfaces and definitions)

@StephenHodgson StephenHodgson added the Ready for review PR finished primary development, open for review label Sep 10, 2019
@SimonDarksideJ
Copy link
Contributor

Looks ok, but will test in the morning to confirm

Copy link
Contributor

@SimonDarksideJ SimonDarksideJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IT DIDN'T CRASH

Err,but it couldn't find some of the packages either :S but that might or might not be a bug :S

@StephenHodgson
Copy link
Contributor Author

I'm not too worried about finding packages once we get the upm server up and running

@StephenHodgson StephenHodgson merged commit 8636357 into development Sep 12, 2019
@StephenHodgson StephenHodgson deleted the fixes/editor-updating-checks branch September 12, 2019 20:03
XRTK-Build-Bot pushed a commit that referenced this pull request Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ready for review PR finished primary development, open for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants