This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
No longer require the service locator to configure profiles #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2019
FejZa
approved these changes
May 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR covers the required changes to all of the profile inspectors to enable them to not require the Service Locator object be setup and initialed in the scene to configure them.
Target of the change:
Is this enhancement for:
Changes:
All references to the
MixedRealityToolkit.Instancehave been removed for the most part and replaced with a dynamic profile reference.This will require the profiles to have to be setup at least once in the main configuration profile to get these reference properly set.