Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Controller Visualisation not behaving as expected #233

Closed
SimonDarksideJ opened this issue Jul 8, 2019 · 1 comment
Closed

Controller Visualisation not behaving as expected #233

SimonDarksideJ opened this issue Jul 8, 2019 · 1 comment
Assignees
Labels
Bug Something isn't working

Comments

@SimonDarksideJ
Copy link
Contributor

XRTK - Mixed Reality Toolkit Bug Report

Describe the bug

The original intention with the Controller Visualisation Configuration, was that it provided ways to OVERRIDE the default configuration of the Visualiser.

In such, with nothing configured, it would visualise the Gizmo models (the model defaults) for al platforms, regardless of whether any overrides were configured. However, today it only renders a model if an override is applied.

To Reproduce

  1. Create new XRTK project and configure
  2. View Visualizer configuration and remove any configured overrides
  3. Run the XRTK project with a headset / controllers connected

Expected behavior

With no override configuration provided, controllers should display with their global defaults

Actual behavior

Unless an override is configured, no controllers show.

Your Setup (please complete the following information)

  • Unity Version 2019.1.9
  • XRTK Version 0.1.11

Target Platform (please complete the following information)

  • ALL platforms with controllers
@SimonDarksideJ SimonDarksideJ added the Bug Something isn't working label Jul 8, 2019
@SimonDarksideJ SimonDarksideJ self-assigned this Jul 8, 2019
SimonDarksideJ added a commit that referenced this issue Jul 11, 2019
* Initial check-in of Visualisation fix for #233

* Reordered the visualisation logic.
Included global pointer parameter

* Updated Default mapping definitions for Touch, resolves pointer issue as Press interactions were mapped to Axis instead of button

* Update spelling and restructure elements

* Minor mapping change after review

* Updated Mapping layout

* Review comments addressed
XRTK-Build-Bot pushed a commit that referenced this issue Jul 15, 2019
* Initial check-in of Visualisation fix for #233

* Reordered the visualisation logic.
Included global pointer parameter

* Updated Default mapping definitions for Touch, resolves pointer issue as Press interactions were mapped to Axis instead of button

* Update spelling and restructure elements

* Minor mapping change after review

* Updated Mapping layout

* Review comments addressed
@SimonDarksideJ
Copy link
Contributor Author

Resolved by #234

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant