Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Commit

Permalink
Fix/471 extension service providers (#472)
Browse files Browse the repository at this point in the history
* Recursively look for generic type arguments on a profile to filter for ServiceConstraint

* Fix BaseExtensionService profile type expected in constructor

* Update XRTK-Core/Packages/com.xrtk.core/Inspectors/Profiles/MixedRealityServiceProviderProfileInspector.cs

Co-Authored-By: Stephen Hodgson <StephenHodgson@users.noreply.github.com>

* Update XRTK-Core/Packages/com.xrtk.core/Extensions/TypeExtensions.cs

Co-Authored-By: Stephen Hodgson <StephenHodgson@users.noreply.github.com>

* Update XRTK-Core/Packages/com.xrtk.core/Definitions/BaseMixedRealityExtensionServiceProfile.cs

Co-Authored-By: Stephen Hodgson <StephenHodgson@users.noreply.github.com>

* Fix class doc

* Fix missing using

* Fix base extension service profile generic type

* Make ServiceConstraint protected to allow for custom override

* Update Tests

* Fix interface base type

* Fix extension service configurations registration

Co-authored-by: Stephen Hodgson <StephenHodgson@users.noreply.github.com>
  • Loading branch information
FejZa and StephenHodgson authored Mar 28, 2020
1 parent 233def2 commit c9278bd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Services/MixedRealityToolkit.cs
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ private void InitializeServiceLocator()
{
if (CreateAndRegisterService(configuration))
{
if (configuration.ConfigurationProfile is BaseMixedRealityExtensionDataProviderProfile extensionServiceProfile)
if (configuration.ConfigurationProfile is BaseMixedRealityExtensionServiceProfile extensionServiceProfile)
{
RegisterServices(extensionServiceProfile.RegisteredServiceConfigurations);
}
Expand Down

0 comments on commit c9278bd

Please sign in to comment.